Unsafe Challenge Overrides #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitribouniol
force-pushed
the
dimitri/challenges
branch
from
8e7965c to
8bfc795
Compare
dimitribouniol
force-pushed
the
dimitri/challenges
branch
from
8bfc795 to
bf2308c
Compare
0xTim
requested changes
Nov 3, 2025
| public var challenge: [UInt8] | ||
| /// The Relying Party should store the challenge temporarily until the authentication flow is complete. When encoding using `Encodable` this is encoded as base64url. | ||
| /// | ||
| /// - Warning: Although the challenge can be changed, doing so is not recommended and can lead to an insecure implementation of the WebAuthn protocol. See ``setUnsafeChallenge(_:)``. |
Member
There was a problem hiding this comment.
Let's just remove this from the API docs, I don't think we need it
Collaborator
Author
There was a problem hiding this comment.
Removed in favor of a SeeAlso
| /// Unsafely change the challenge that will be delivered to the client. | ||
| /// | ||
| /// - Warning: Although the challenge can be changed, doing so is not recommended and can lead to an insecure implementation of the WebAuthn protocol. | ||
| public mutating func setUnsafeChallenge(_ newValue: [UInt8]) { |
Member
There was a problem hiding this comment.
Suggested change
| public mutating func setUnsafeChallenge(_ newValue: [UInt8]) { | |
| public mutating func unsafeSetChallenge(_ newValue: [UInt8]) { |
| /// encoding using `Encodable`, the challenge is base64url encoded. | ||
| public let challenge: [UInt8] | ||
| /// | ||
| /// - Warning: Although the challenge can be changed, dooing so is not recommended and can lead to an insecure implementation of the WebAuthn protocol. See ``setUnsafeChallenge(_:)``. |
Collaborator
Author
There was a problem hiding this comment.
I'll change them right now!
Collaborator
Author
There was a problem hiding this comment.
Removed in favor of a SeeAlso.
Collaborator
Author
There was a problem hiding this comment.
Actually, should I have kept the warning on unsafeSetChallenge?
Member
There was a problem hiding this comment.
Yeah keep the warning on unsafeSetChallenge, we just don't need to include it on the main parameter
dimitribouniol
force-pushed
the
dimitri/challenges
branch
from
bcbbefb to
495b3ae
Compare
0xTim
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still unclear why folks would want to change how challenges are generated, but this change let's them do so with the appropriate warnings in place by adding unsafe setters for changing the challenge returned by the manager. Closes #72